From 4fabe864f15c009a3201983c26ed27a7afa72d21 Mon Sep 17 00:00:00 2001 From: bpmcdevitt Date: Fri, 19 Aug 2022 10:04:24 -0500 Subject: [PATCH] use d.get instead of direct assignment with crazy long if else condition. thanks @ageorge --- .../meta_release_to_json.py | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/ubuntu_package_puller/meta_release_to_json.py b/tools/ubuntu_package_puller/meta_release_to_json.py index 858671d..782bc06 100644 --- a/tools/ubuntu_package_puller/meta_release_to_json.py +++ b/tools/ubuntu_package_puller/meta_release_to_json.py @@ -71,16 +71,16 @@ if __name__ == '__main__': for d in meta_release: keys = d.keys() meta_release_obj = MetaRelease( - dist = d['dist'] if 'dist' in keys else None, - name = d['name'] if 'name' in keys else None, - version = d['version'] if 'version' in keys else None, - supported = d['supported'] if 'supported' in keys else None, - description = d['description'] if 'description' in keys else None, - release_file = d['release-file'] if 'release-file' in keys else None, - release_notes = d['releasenotes'] if 'releasenotes' in keys else None, - release_notes_html = d['releasenoteshtml'] if 'releasenoteshtml' in keys else None, - upgrade_tool = d['upgradetool'] if 'upgradetool' in keys else None, - upgrade_tool_signature = d['upgradetoolsignature'] if 'upgradetoolsignature' in keys else None + dist = d.get('dist', None), + name = d.get('name', None), + version = d.get('version', None), + supported = d.get('supported', None), + description = d.get('description', None), + release_file = d.get('release-file', None), + release_notes = d.get('releasenotes', None), + release_notes_html = d.get('releasenoteshtml', None), + upgrade_tool = d.get('upgradetool', None), + upgrade_tool_signature = d.get('upgradetoolsignature', None) ) print(meta_release_obj.to_json())